[GitHub] [druid] suneet-s commented on a change in pull request #11553: Fix ingestion task failure when no input split to process

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #11553:
URL: https://github.com/apache/druid/pull/11553#discussion_r683849572



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java
##########
@@ -289,13 +289,15 @@ private void stopInternal()
   @Override
   public void collectReport(SubTaskReportType report)
   {
-    taskMonitor.collectReport(report);
+    if (taskMonitor != null) {
+      taskMonitor.collectReport(report);
+    }

Review comment:
       Is there a way to have static analysis flag all these uses? I've tried using combinations of `@Nullable`(doesn't realize that once it's set, it's good for the rest of the method) and `@MonotonicNonNull` but haven't been able to get intelliJ to flag these issues for me locally yet. I figured I would just leave a comment here and maybe you will have better luck




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org