[jira] [Commented] (CALCITE-4555) Invalid zero literal value is used for TIMESTAMP WITH LOCAL TIME ZONE type in RexBuilder

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311940#comment-17311940 ] 

Julian Hyde commented on CALCITE-4555:
--------------------------------------

That code is in a private method, so when fixing, try to devise a user test (e.g. a SQL query) that would trigger it. You might find a few issues along the way. Evidently {{TIMESTAMP WITH TIME ZONE}} is not well tested.

> Invalid zero literal value is used for TIMESTAMP WITH LOCAL TIME ZONE type in RexBuilder
> ----------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4555
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4555
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Leonard Xu
>            Priority: Major
>
>  The zero literal value for TIMESTAMP WITH LOCAL TIME ZONE type is used in `org.apache.calcite.rex.RexBuilder`
> {code:java}
>     case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
>       return new TimestampString(0, 0, 0, 0, 0, 0);
>    //TimestampString(int year, int month, int day, int h, int m, int s)
> {code}
> the month and day should never be zero, I think the zero value should be '1970-01-01 00:00:00'(epoch 0 second).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)