You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lizhanhui <gi...@git.apache.org> on 2017/08/07 08:16:21 UTC
[GitHub] incubator-rocketmq pull request #142: [ROCKETMQ-255] Fix offsetStore being n...
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/142
[ROCKETMQ-255] Fix offsetStore being null after consumers start()
Associated JIRA ticket is: https://issues.apache.org/jira/browse/ROCKETMQ-255
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq offset_store
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 6e565434a82fe6466913fce69608c173f19d1d35
Author: Li Zhanhui <li...@gmail.com>
Date: 2017-08-07T08:07:35Z
DefaultMQ{Push|Pull}Consumer#getOffsetStore should not return null after start()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
[](https://coveralls.io/builds/12774581)
Coverage decreased (-0.04%) to 38.701% when pulling **18cb81b21ad6fa03b457c037aa474123b93caf1f on lizhanhui:offset_store** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
LGTM @zhouxinyu @vsair @Jaskey please help do a review?
---
[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
Normalize the naming is surely good to have. I'd update the naming soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
[](https://coveralls.io/builds/12719494)
Coverage increased (+0.2%) to 38.932% when pulling **6e565434a82fe6466913fce69608c173f19d1d35 on lizhanhui:offset_store** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
I created this thread just to address some unit test naming problem. Do we need normalize here ? naming are various nowadays, IMO, methodTest_condition or testMethond_condition may be a good practice, thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #142: [ROCKETMQ-255] Fix offsetStore being null aft...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/142
[](https://coveralls.io/builds/12719494)
Coverage increased (+0.2%) to 38.932% when pulling **6e565434a82fe6466913fce69608c173f19d1d35 on lizhanhui:offset_store** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---