You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/02 01:24:48 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38866: [SPARK-40970][CONNECT][PYTHON] Support List[Column] for Join's on argument
HyukjinKwon commented on code in PR #38866:
URL: https://github.com/apache/spark/pull/38866#discussion_r1037706761
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -468,7 +468,7 @@ def take(self, num: int) -> List[Row]:
def join(
self,
other: "DataFrame",
- on: Optional[Union[str, List[str], Column]] = None,
+ on: Optional[Union[str, List[str], Column, List[Column]]] = None,
Review Comment:
Just dropping a comment. It should actually be able to accept a tuple too .. or `Iterable` .. but I am fine because that's what's already done in PySpark DataFrame.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org