You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 20:35:30 UTC

[GitHub] [arrow] nevi-me commented on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

nevi-me commented on pull request #8598:
URL: https://github.com/apache/arrow/pull/8598#issuecomment-724263021


   A few weeks/months ago when I was trying to work on bit slicing, `bit_vec` was recommended over at Reddit, so I think it's generally a good dependency for us to carry along, as it'll also have more eyes over it, and more time being used.
   
   I'm going to look at what the reason for the perf regressions is, during the week in my evenings. I haven't been able to profile criterion benchmarks with the tool that I use (https://superluminal.eu/), so I'll write some small application(s) so I can get the perf profiles for this.
   I'll revert back after doing this, as I'd also like to understand the cause of the regression before continuing with this PR :)
   
   @vertexclique @jorgecarleitao there's been work on Java and C++ to support big-endian architectures; so maybe we can check in on previous mailing list discussions for guidance. I think CI might be the main concern (incl for arm-v7 support).
   
   I'd also prefer if we separate the big-endian functionality, and work on it as a separate PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org