You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Emmanuel Lécharny <el...@gmail.com> on 2023/04/05 08:15:34 UTC
Re: Parent pom updates
Hi,
some update:
the failure was due to an unecessary dependency decalaration in the
ApacheDS osgi-integ test. I removed it and tests are passing with
maven-surefire-3.0.0.
I'll cancel the Directory project 47 release I cut yesterday evening and
recreate it with the proper version.
Thanks!
On 30/03/2023 10:37, Emmanuel Lécharny wrote:
> Hi,
>
> I have checked all the changes made in directory-project, and they are
> all ok but the surefire-plugin, which does not work with
> directory-server in 3.0.0.
>
> I had to revert to 3.0.0-M5, otherwise I get such an error:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test
> (default-test) on project apacheds-osgi-integ: Execution default-test of
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test
> failed: An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test:
> java.lang.NoSuchMethodError:
> org.apache.maven.surefire.api.testset.RunOrderParameters.<init>(Ljava/lang/String;Ljava/io/File;Ljava/lang/Long;)V
> [ERROR] -----------------------------------------------------
> [ERROR] realm =
> plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6
> [ERROR] strategy =
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/plugins/maven-surefire-plugin/3.0.0-M6/maven-surefire-plugin-3.0.0-M6.jar
> [ERROR] urls[1] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-junit47/3.0.0-M5/surefire-junit47-3.0.0-M5.jar
> [ERROR] urls[2] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/common-junit48/3.0.0-M5/common-junit48-3.0.0-M5.jar
> [ERROR] urls[3] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/common-junit4/3.0.0-M5/common-junit4-3.0.0-M5.jar
> [ERROR] urls[4] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/common-junit3/3.0.0-M5/common-junit3-3.0.0-M5.jar
> [ERROR] urls[5] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/common-java5/3.0.0-M5/common-java5-3.0.0-M5.jar
> [ERROR] urls[6] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-grouper/3.0.0-M5/surefire-grouper-3.0.0-M5.jar
> [ERROR] urls[7] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-api/3.0.0-M5/surefire-api-3.0.0-M5.jar
> [ERROR] urls[8] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-logger-api/3.0.0-M5/surefire-logger-api-3.0.0-M5.jar
> [ERROR] urls[9] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/maven-surefire-common/3.0.0-M6/maven-surefire-common-3.0.0-M6.jar
> [ERROR] urls[10] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-extensions-api/3.0.0-M6/surefire-extensions-api-3.0.0-M6.jar
> [ERROR] urls[11] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-booter/3.0.0-M6/surefire-booter-3.0.0-M6.jar
> [ERROR] urls[12] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-extensions-spi/3.0.0-M6/surefire-extensions-spi-3.0.0-M6.jar
> [ERROR] urls[13] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/3.1.1/maven-common-artifact-filters-3.1.1.jar
> [ERROR] urls[14] =
> file:/Users/elecharny/.m2/repository/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar
> [ERROR] urls[15] =
> file:/Users/elecharny/.m2/repository/org/codehaus/plexus/plexus-java/1.1.1/plexus-java-1.1.1.jar
> [ERROR] urls[16] =
> file:/Users/elecharny/.m2/repository/org/ow2/asm/asm/9.2/asm-9.2.jar
> [ERROR] urls[17] =
> file:/Users/elecharny/.m2/repository/com/thoughtworks/qdox/qdox/2.0.1/qdox-2.0.1.jar
> [ERROR] urls[18] =
> file:/Users/elecharny/.m2/repository/org/apache/maven/surefire/surefire-shared-utils/3.0.0-M6/surefire-shared-utils-3.0.0-M6.jar
> [ERROR] Number of foreign imports: 1
> [ERROR] import: Entry[import from realm
> ClassRealm[project>org.apache.directory.server:apacheds-parent:2.0.0.AM27-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
> [ERROR]
> [ERROR] -----------------------------------------------------
>
>
>
> On 30/03/2023 09:07, Emmanuel Lécharny wrote:
>> Hi Brian, Shawn
>>
>> On 29/03/2023 14:32, Shawn McKinney wrote:
>>>
>>>
>>>> On Mar 27, 2023, at 2:29 PM, Brian Demers <bd...@apache.org> wrote:
>>>>
>>>> I took a pass at updating the Directory parent pom.
>>>>
>>>> I updated to the latest apache pom and a bunch of other plugin
>>>> versions:
>>>> https://github.com/apache/directory-project/pull/3
>>>>
>>>> Of note, I changed how the compiler plugin gets configured; this
>>>> removes a deprecated (no-op) warning from child projects and moves
>>>> the config to maven properties which makes them easier to update in
>>>> child projects (or possibly profiles)
>>>>
>>>> There is a lot in PR, so if someone feels strongly about it, I can
>>>> break it up into smaller sections, maybe something like parent pom
>>>> version, plugin versions, and compiler plugin config)
>>>>
>>>
>>> Thanks for doing this Brian, much overdo. I glanced at it and it
>>> looks OK.
>>
>> I'll commit the change.
>>
>>
>>>
>>>> I created another PR to remove the dead Geronimo tools plugin.
>>>> https://github.com/apache/directory-project/pull/4
>>>>
>>>> There may be more opinions over this one? I ran into issues with how
>>>> it worked with the example projects that are built in Directory
>>>> SCIMple, the NOTICE file was not detected. I ended up hacking
>>>> around it by disabling some of the checks:
>>>> https://github.com/apache/directory-scimple/blob/7e08c6a0b3da4681845f3a565e72eb0d5f620b55/scim-server-examples/scim-server-memory/pom.xml#L62-L68
>>>>
>>>> This plugin is also not marked as threadsafe when trying to perform
>>>> parallelized maven builds.
>>>>
>>>> For the most part, the Rat plugin _should_ accomplish similar goals.
>>>> My suggestion is to remove this plugin from the Directory parent
>>>> pom. Any projects that still require this plugin can add the
>>>> configuration directly in its pom.
>>>>
>>>
>>> So here I’m confused. Our projects must pass the rat plugin checks
>>> during release. You’re not recommending we disable those checks. Is
>>> it we disable the Geronimo tools plugin (I have no idea what it does)
>>> and use rat to perform its checks instead? Would want to understand
>>> better what’s going on here.
>>>
>>> Sorry, don’t have better knowlege. Perhaps Emmanuel or Stefan can
>>> chime in. Definitely want to test out the changes in the other
>>> projects to ensure releases aren’t impacted down the road.
>>
>>
>> The rat plugin should take care of all the missing N&L files, so the
>> Geronimo tool should not be necessary. I'll check that on the API,
>> AapcheDS and Studio.
>>
>> Thanks !
>>
>>
>
--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecharny@busit.com https://www.busit.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org