[GitHub] [incubator-druid] suneet-s commented on a change in pull request #8909: Optimize CachingLocalSegmentAllocator#getSequenceName

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #8909: Optimize CachingLocalSegmentAllocator#getSequenceName
URL: https://github.com/apache/incubator-druid/pull/8909#discussion_r359084385
 
 

 ##########
 File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/RangePartitionCachingLocalSegmentAllocatorTest.java
 ##########
 @@ -141,6 +142,16 @@ public void allocatesCorrectShardSpecsForLastPartition()
     testAllocate(row, interval, partitionNum, null);
   }
 
+  @Test
+  public void test_getSequenceName_forIntervalAndRow_shouldUseISOFormatAndPartitionNumForRow()
 
 Review comment:
   can you recommend a name? I like this format because it's explicit about what the test is doing
   
   test_<functionUnderTest>_<condition>_<expectedResult>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org