You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/10/28 18:13:48 UTC
Review Request 27289: Fixing error reporting in v1 client updater.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-901
https://issues.apache.org/jira/browse/AURORA-901
Repository: aurora
Description
-------
The v1 base.py is not using a new `details` field to format error message.
Diffs
-----
src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
src/test/python/apache/aurora/client/test_base.py PRE-CREATION
Diff: https://reviews.apache.org/r/27289/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 27289: Fixing error reporting in v1 client updater.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/#review58862
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/api/updater.py
<https://reviews.apache.org/r/27289/#comment100014>
What is "the deprecation"? Can you point to a ticket?
- Bill Farner
On Oct. 28, 2014, 8:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27289/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-901
> https://issues.apache.org/jira/browse/AURORA-901
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The v1 base.py is not using a new `details` field to format error message.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
> src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
> src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
> src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
> src/test/python/apache/aurora/client/api/test_updater.py f0e45e3f33de0dcb87251021bbf96bfea6f38ea8
> src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
> src/test/python/apache/aurora/client/test_base.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27289/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27289: Fixing error reporting in v1 client updater.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/#review58863
-----------------------------------------------------------
Master (9fb2ce4) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
- Aurora ReviewBot
On Oct. 28, 2014, 8:52 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27289/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:52 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-901
> https://issues.apache.org/jira/browse/AURORA-901
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The v1 base.py is not using a new `details` field to format error message.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
> src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
> src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
> src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
> src/test/python/apache/aurora/client/api/test_updater.py f0e45e3f33de0dcb87251021bbf96bfea6f38ea8
> src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
> src/test/python/apache/aurora/client/test_base.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27289/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27289: Fixing error reporting in v1 client updater.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 8:52 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Added deprecation ticket ref.
Bugs: AURORA-901
https://issues.apache.org/jira/browse/AURORA-901
Repository: aurora
Description
-------
The v1 base.py is not using a new `details` field to format error message.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
src/test/python/apache/aurora/client/api/test_updater.py f0e45e3f33de0dcb87251021bbf96bfea6f38ea8
src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
src/test/python/apache/aurora/client/test_base.py PRE-CREATION
Diff: https://reviews.apache.org/r/27289/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 27289: Fixing error reporting in v1 client updater.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 8:41 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Fixed updater to dual-write error messages to comply with scheduler approach.
Bugs: AURORA-901
https://issues.apache.org/jira/browse/AURORA-901
Repository: aurora
Description
-------
The v1 base.py is not using a new `details` field to format error message.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
src/test/python/apache/aurora/client/api/test_updater.py f0e45e3f33de0dcb87251021bbf96bfea6f38ea8
src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
src/test/python/apache/aurora/client/test_base.py PRE-CREATION
Diff: https://reviews.apache.org/r/27289/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 27289: Fixing error reporting in v1 client updater.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/#review58851
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Oct. 28, 2014, 5:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27289/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 5:13 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-901
> https://issues.apache.org/jira/browse/AURORA-901
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The v1 base.py is not using a new `details` field to format error message.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
> src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
> src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
> src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
> src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
> src/test/python/apache/aurora/client/test_base.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27289/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27289: Fixing error reporting in v1 client updater.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/#review58829
-----------------------------------------------------------
Master (9fb2ce4) is red with this patch.
./build-support/jenkins/build.sh
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exit Log an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fast Run tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
- Aurora ReviewBot
On Oct. 28, 2014, 5:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27289/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 5:13 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-901
> https://issues.apache.org/jira/browse/AURORA-901
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The v1 base.py is not using a new `details` field to format error message.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701
> src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700
> src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a
> src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14
> src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1
> src/test/python/apache/aurora/client/test_base.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27289/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>