You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/05/21 17:35:01 UTC
Review Request 70696: Renamed sets of role names from 'roles' into
'roleNames'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70696/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9701
https://issues.apache.org/jira/browse/MESOS-9701
Repository: mesos
Description
-------
This patch renames the sets of strings named `roles` into `roleNames`
throughout the hierarchial allocator code. This is done to keep
consistency with the renaming of `string role` introduced in the
preceding patch and to avoid confusing readers by the name `roles`
after `struct Role` is introduced.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp c2058baca5159da4cdcab77afd5de3c0d5ae6c48
src/master/allocator/mesos/hierarchical.cpp 6df9a3b4ef470e57862815a862494cdb5e26d3e3
Diff: https://reviews.apache.org/r/70696/diff/1/
Testing
-------
make check
Thanks,
Andrei Sekretenko
Re: Review Request 70696: Renamed sets of role names from 'roles' into
'roleNames'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70696/#review215430
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70693, 70694, 70695, 70696]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 21, 2019, 5:35 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70696/
> -----------------------------------------------------------
>
> (Updated May 21, 2019, 5:35 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9701
> https://issues.apache.org/jira/browse/MESOS-9701
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames the sets of strings named `roles` into `roleNames`
> throughout the hierarchial allocator code. This is done to keep
> consistency with the renaming of `string role` introduced in the
> preceding patch and to avoid confusing readers by the name `roles`
> after `struct Role` is introduced.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp c2058baca5159da4cdcab77afd5de3c0d5ae6c48
> src/master/allocator/mesos/hierarchical.cpp 6df9a3b4ef470e57862815a862494cdb5e26d3e3
>
>
> Diff: https://reviews.apache.org/r/70696/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Sekretenko
>
>