You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/19 20:37:34 UTC

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9404: fix(ui): table only displaying first 10 results when not explicitly paginated

Jackie-Jiang commented on code in PR #9404:
URL: https://github.com/apache/pinot/pull/9404#discussion_r974667936


##########
pinot-controller/src/main/resources/app/components/Table.tsx:
##########
@@ -292,6 +292,14 @@ export default function CustomizedTables({
     setPage(newPage);
   };
 
+  React.useEffect(() => {
+    if(isPagination) {

Review Comment:
   (minor)
   ```suggestion
       if (isPagination) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org