[GitHub] [mynewt-nimble] v01d commented on pull request #878: Add support for NuttX

[GitBox <gi...@apache.org>]

v01d commented on pull request #878:
URL: https://github.com/apache/mynewt-nimble/pull/878#issuecomment-718964467


   Ok, I just addressed the style issues and also found how to define a variable to distinguish NuttX from Linux. There are just two things worth mentioning:
   - a check on a semaphore which is actually a race condition (see annotation above) since it checks the semaphore at a time which may be incorrect (in NuttX this was triggered incorrectly, possibly on Linux it was slower and it wasn't triggered)
   - I had to disable LOG_* defines in log.h, due to conflicts of syslog() defines which NuttX has. It was suggested in #864 that I could redefine include path to my own log.h, and to do this I would have to change all includes of `log.h` from using `"` to `<`/`>` for that to work. But I feel hesitant to do so since it sounds a bit hack to do that only for that include. If you confirm it is OK to do so, I will add that as well. Otherwise, I think the simpler change is to remove those LOG_* macros which are not used in nimBLE (or maybe conditionally define them based on MYNEWT?)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org