[GitHub] [iceberg] rajarshisarkar commented on pull request #3698: AWS: Add unit tests for GlueCatalog's isValidIdentifier method

[GitBox <gi...@apache.org>]

rajarshisarkar commented on pull request #3698:
URL: https://github.com/apache/iceberg/pull/3698#issuecomment-992450331


   Hi @jackye1995, This change is independent of https://github.com/apache/iceberg/pull/3668. 
   
   - I changed `GlueCatalog.isValidIdentifier` to return `false` always and then ran `TestGlueCatalog` (all 21 test cases passed).
   - I changed `GlueCatalog.isValidIdentifier` to return `true` always and then ran `TestGlueCatalog` (all 21 test cases passed).
   
   The current master doesn't seem to have unit tests to check the behaviour of `GlueCatalog.isValidIdentifier`. Hence, this PR adds few unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org