[GitHub] [calcite] libenchao commented on a diff in pull request #2791: [CALCITE-5134] Queries with subquery inside select list does not work if subquery uses table from left join

[GitBox <gi...@apache.org>]

libenchao commented on code in PR #2791:
URL: https://github.com/apache/calcite/pull/2791#discussion_r898604949


##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -4883,7 +4883,14 @@ void setRoot(List<RelNode> inputs) {
           int i = 0;
           int offset = 0;
           for (SqlValidatorNamespace c : ancestorScope1.getChildren()) {
-            builder.addAll(c.getRowType().getFieldList());
+            final boolean isNullable = ancestorScope1.children.get(i).isNullable();

Review Comment:
   Yes, it's more cleaner. I've revised it. Thanks for your review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org