You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/09 06:37:10 UTC

[GitHub] [tvm] tmoreau89 commented on a change in pull request #7607: [SPIRV] Minor update to TIR sort to make it work on VK/SPIR-V

tmoreau89 commented on a change in pull request #7607:
URL: https://github.com/apache/tvm/pull/7607#discussion_r589977760



##########
File path: tests/python/topi/python/test_topi_sort.py
##########
@@ -75,7 +75,7 @@ def check_device(device):
         f(tvm_data, tvm_out)
         tvm.testing.assert_allclose(tvm_out.asnumpy(), np_sort, rtol=1e0)
 
-    for device in ["llvm", "cuda", "opencl"]:
+    for device in ["llvm", "cuda", "opencl", "vulkan", "nvptx"]:

Review comment:
       Thanks @masahi  - in the case of vulkan here the tests won't be run until we add vulkan to our CI docker image, right? These are just tested locally?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org