You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/05/01 22:49:30 UTC
[jira] Created: (ZOOKEEPER-389) add help/usage to the c shell cli.c
add help/usage to the c shell cli.c
-----------------------------------
Key: ZOOKEEPER-389
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
Project: Zookeeper
Issue Type: Improvement
Components: c client
Reporter: Patrick Hunt
Priority: Minor
Fix For: 3.2.0
The current c shell should have help information (in the shell)
currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-389) add help/usage to the
c shell cli.c
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705155#action_12705155 ]
Patrick Hunt edited comment on ZOOKEEPER-389 at 5/1/09 3:25 PM:
----------------------------------------------------------------
Added two new commands to the shell:
help outputs help on available shell comands
verbose toggles btw WARN (default) and DEBUG logging level output
this will fail hudsonbot as cli.c is a command line shell util
was (Author: phunt):
Added two new commands to the shell:
help outputs help on available shell comands
verbose toggles btw WARN (default) and DEBUG logging level output
this will fail tests as cli.c is a command line shell util
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-389) add help/usage to the c shell
cli.c
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707390#action_12707390 ]
Hudson commented on ZOOKEEPER-389:
----------------------------------
Integrated in ZooKeeper-trunk #303 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/303/])
. add help/usage to the c shell cli.c (phunt via mahadev)
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-389) add help/usage to the c shell cli.c
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-389:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. ill open a new jira for making the api public. thanks pat.
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-389) add help/usage to the c shell
cli.c
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705165#action_12705165 ]
Hadoop QA commented on ZOOKEEPER-389:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407042/ZOOKEEPER-389.patch
against trunk revision 769885.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/58/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/58/console
This message is automatically generated.
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-389) add help/usage to the c shell
cli.c
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705898#action_12705898 ]
Mahadev konar commented on ZOOKEEPER-389:
-----------------------------------------
good to see some help in cli in c.
the patch introduces a method
{code}
state2String(int state)
{code}
in cli.c, we already have a method
{code}
static __attribute__ ((unused)) const char* state2String(int state){
{code}
in zookeeper.c. We can make this non local and use this instead of creating another one in cli.c.
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-389) add help/usage to the c shell cli.c
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-389:
-----------------------------------
Status: Patch Available (was: Open)
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-389) add help/usage to the c shell cli.c
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-389:
-----------------------------------
Attachment: ZOOKEEPER-389.patch
Added two new commands to the shell:
help outputs help on available shell comands
verbose toggles btw WARN (default) and DEBUG logging level output
this will fail tests as cli.c is a command line shell util
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-389) add help/usage to the c shell
cli.c
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706736#action_12706736 ]
Patrick Hunt commented on ZOOKEEPER-389:
----------------------------------------
I didn't want to change the public API so I copied it privately instead. Adding a new feature to the
API for such a thing makes sense, but I didn't want to do it for this JIRA. Perhaps you could
commit this and add a new JIRA for 4.0 to address this?
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-389) add help/usage to the c shell
cli.c
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-389:
--------------------------------------
Assignee: Patrick Hunt
> add help/usage to the c shell cli.c
> -----------------------------------
>
> Key: ZOOKEEPER-389
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-389
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-389.patch
>
>
> The current c shell should have help information (in the shell)
> currently it's hard to know what commands are available
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.