You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/11/28 11:15:56 UTC

[GitHub] [opennlp] kinow commented on a diff in pull request #440: OPENNLP-1341: Fix make the conllu pos sample stream constructor public

kinow commented on code in PR #440:
URL: https://github.com/apache/opennlp/pull/440#discussion_r1033416140


##########
opennlp-tools/src/main/java/opennlp/tools/formats/conllu/ConlluSentenceSampleStreamFactory.java:
##########
@@ -28,6 +28,9 @@
 import opennlp.tools.util.InputStreamFactory;
 import opennlp.tools.util.ObjectStream;
 
+/**
+ * <b>Note:</b> Do not use this class, internal use only!
+ */

Review Comment:
   In Apache Commons I think it is common to have an "internal" subpackage for classes that must not be used by external users. Maybe we should move these classes too? That way you could quickly identify use of internal API classes in other projects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org