You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2024/10/08 14:40:57 UTC

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21906


Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................

IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]

test_read_position_deletes modifies a table (COMPUTE STATS / DROP STATS)
during its execution. So when the test executes in parallel we can see
inconsistent results.

This change moves the COMPUTE/DROP STATS operations to a separate test
that is executed serially. Also adds SHOW COLUMN STATS which was not
tested before.

Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
---
A testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test
A testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-stats.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test
M tests/query_test/test_iceberg.py
5 files changed, 418 insertions(+), 325 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/21906/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21906

to look at the new patch set (#2).

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................

IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]

test_read_position_deletes modifies a table (COMPUTE STATS / DROP STATS)
during its execution. So when the test executes in parallel we can see
inconsistent results.

This change moves the COMPUTE/DROP STATS operations to a separate test
that is executed serially. Also adds SHOW COLUMN STATS which was not
tested before.

Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
---
A testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test
A testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-stats.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test
M tests/query_test/test_iceberg.py
5 files changed, 431 insertions(+), 325 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/21906/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 2:

(2 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/21906/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test:

http://gerrit.cloudera.org:8080/#/c/21906/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test@3
PS1, Line 3: DROP STATS iceberg_v2_no_deletes_orc;
> Could start with DROP STATS to ensure that previous failed tests can have n
Done


http://gerrit.cloudera.org:8080/#/c/21906/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/21906/1/tests/query_test/test_iceberg.py@1534
PS1, Line 1534:   def test_read_position_deletes_compute_stats(self, vector):
> Can you add a comment about why it needs to be executed serially?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 14:08:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 21:40:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 16:33:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 15:14:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21906/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test:

http://gerrit.cloudera.org:8080/#/c/21906/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test@3
PS1, Line 3: COMPUTE STATS iceberg_v2_no_deletes_orc
Could start with DROP STATS to ensure that previous failed tests can have no effect on the next test run. (+same for other tables)


http://gerrit.cloudera.org:8080/#/c/21906/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/21906/1/tests/query_test/test_iceberg.py@1534
PS1, Line 1534:   def test_read_position_deletes_compute_stats(self, vector):
Can you add a comment about why it needs to be executed serially?



-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Oct 2024 16:10:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11028/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 16:33:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17122/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Oct 2024 15:06:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2024 14:33:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13346, IMPALA-13420: Deflake test read position deletes[ orc]

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21906 )

Change subject: IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]
......................................................................

IMPALA-13346, IMPALA-13420: Deflake test_read_position_deletes[_orc]

test_read_position_deletes modifies a table (COMPUTE STATS / DROP STATS)
during its execution. So when the test executes in parallel we can see
inconsistent results.

This change moves the COMPUTE/DROP STATS operations to a separate test
that is executed serially. Also adds SHOW COLUMN STATS which was not
tested before.

Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Reviewed-on: http://gerrit.cloudera.org:8080/21906
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc-stats.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test
A testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-stats.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes.test
M tests/query_test/test_iceberg.py
5 files changed, 431 insertions(+), 325 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee8cdac9c631a17436250dc60528a8545e668e2d
Gerrit-Change-Number: 21906
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>