You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/11/26 02:14:47 UTC
Review Request 40725: Test connection for Ranger from ambari takes
the DB flavor selected before
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40725/
-----------------------------------------------------------
Review request for Ambari, Richard Zang and Xi Wang.
Bugs: AMBARI-14080
https://issues.apache.org/jira/browse/AMBARI-14080
Repository: ambari
Description
-------
STR:
On Add Service wizard while adding Ranger service, select MySQL database
Test connection for system DBA user.This happens successfully
Switch the DB to MSSQL
Again try test connection
Expected Result: MSSQL Jar should be used for test connection and if MSSQL is correctly setup test connection should pass
Actual Result: MySQL connection Jar is used and test connection fails
This is due to the incorrect API invoked by the ambari-web.
dbname field in the API is not updated when database flavor is changed and API is triggered via "Test Connection" action
Diffs
-----
ambari-web/app/views/common/configs/widgets/test_db_connection_widget_view.js 199aac6
Diff: https://reviews.apache.org/r/40725/diff/
Testing
-------
verified that the patch resolves the issue on the cluster and ambari-web unit tests passes with the patch:
10229 tests complete (12 seconds)
104 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 40725: Test connection for Ranger from ambari
takes the DB flavor selected before
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40725/#review108080
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On Nov. 26, 2015, 1:16 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40725/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 1:16 a.m.)
>
>
> Review request for Ambari, Richard Zang and Xi Wang.
>
>
> Bugs: AMBARI-14080
> https://issues.apache.org/jira/browse/AMBARI-14080
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> On Add Service wizard while adding Ranger service, select MySQL database
> Test connection for system DBA user.This happens successfully
> Switch the DB to MSSQL
> Again try test connection
>
> Expected Result: MSSQL Jar should be used for test connection and if MSSQL is correctly setup test connection should pass
> Actual Result: MySQL connection Jar is used and test connection fails
>
> This is due to the incorrect API invoked by the ambari-web.
> dbname field in the API is not updated when database flavor is changed and API is triggered via "Test Connection" action
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/configs/widgets/test_db_connection_widget_view.js 199aac6
>
> Diff: https://reviews.apache.org/r/40725/diff/
>
>
> Testing
> -------
>
> verified that the patch resolves the issue on the cluster and ambari-web unit tests passes with the patch:
> 10229 tests complete (12 seconds)
> 104 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 40725: Test connection for Ranger from ambari
takes the DB flavor selected before
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40725/
-----------------------------------------------------------
(Updated Nov. 26, 2015, 1:16 a.m.)
Review request for Ambari, Richard Zang and Xi Wang.
Bugs: AMBARI-14080
https://issues.apache.org/jira/browse/AMBARI-14080
Repository: ambari
Description
-------
STR:
On Add Service wizard while adding Ranger service, select MySQL database
Test connection for system DBA user.This happens successfully
Switch the DB to MSSQL
Again try test connection
Expected Result: MSSQL Jar should be used for test connection and if MSSQL is correctly setup test connection should pass
Actual Result: MySQL connection Jar is used and test connection fails
This is due to the incorrect API invoked by the ambari-web.
dbname field in the API is not updated when database flavor is changed and API is triggered via "Test Connection" action
Diffs (updated)
-----
ambari-web/app/views/common/configs/widgets/test_db_connection_widget_view.js 199aac6
Diff: https://reviews.apache.org/r/40725/diff/
Testing
-------
verified that the patch resolves the issue on the cluster and ambari-web unit tests passes with the patch:
10229 tests complete (12 seconds)
104 tests pending
Thanks,
Jaimin Jetly