[GitHub] [james-project] vttranlina commented on a diff in pull request #1510: Make reactive AnnotationMapper, MailboxAnnotationListener, IMAP GetMetadata & SetMetadata processor

["vttranlina (via GitHub)" <gi...@apache.org>]

vttranlina commented on code in PR #1510:
URL: https://github.com/apache/james-project/pull/1510#discussion_r1166233397


##########
mailbox/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerAnnotationTest.java:
##########
@@ -105,46 +110,49 @@ void updateAnnotationsShouldThrowExceptionWhenDoesNotLookupMailbox() {
         when(mailboxMapper.findMailboxByPath(eq(mailboxPath))).thenReturn(Mono.error(new MailboxException()));
 
         assertThatThrownBy(() -> annotationManager.updateAnnotations(mailboxPath, session, ImmutableList.of(PRIVATE_ANNOTATION)))
-            .hasCauseInstanceOf(MailboxException.class);
+            .isInstanceOf(MailboxException.class);

Review Comment:
   Why?
   - In `MailboxManagerTest`, we assert by `isInstanceOf` API -> we should keep similar for both
   - The original of this test is `isInstanceOf`, and after commit 5ccf47c38a651653a79283f9f83b491d72b852e9 (JAMES-3167 Reactify MailboxMapper), we change it to `hasCauseInstanceOf`, So IMO the revert lit is not a big deal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org