You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2023/09/12 21:48:17 UTC

[GitHub] [maven-site] slawekjaranowski opened a new pull request, #449: Improvements to release procedure

slawekjaranowski opened a new pull request, #449:
URL: https://github.com/apache/maven-site/pull/449

   - link to doc of GPG key preparation
   - more detail about preparing release notes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #449: Improvements to release procedure

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #449:
URL: https://github.com/apache/maven-site/pull/449#discussion_r1334559051


##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -60,6 +62,38 @@ Performing a Maven Project Release
   If the item you are planning to release is not using the most recent version of its parent
   (see {{{../../pom/}parent POMs}} index), consider taking this opportunity to update to it.
 
+* Consider updating the project dependencies
+
+  Generally it is a good that project use tha latest available versions of used dependencies.
+
+* Prepare release notes
+
+ * check all commits since latest release, all mentioned issue should be connected with release notes
+
+ * all issues should be fixed and <<CLOSED>>
+
+ * all issues should be <<assigned>> to responsible person, which fixed or merged fix

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] slawekjaranowski commented on pull request #449: Improvements to release procedure

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #449:
URL: https://github.com/apache/maven-site/pull/449#issuecomment-1732545435

   > Just FYI I did for myself a "note" (w/ commands to run) reminder, maybe is good to have them on this page as well? https://github.com/apache/maven-indexer/blob/master/RELEASE.md
   > 
   > Edit: typically it is **good thing** (and is my practice) to run `mvn -P reporting site site:stage` BEFORE actual release, as I had cases where _site generation failed after release (ie. due javadoc issue)_.
   
   for site we have a step `Make sure that site compilation works` with command
   
   other commands can be added in next PR 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] cstamas commented on pull request #449: Improvements to release procedure

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #449:
URL: https://github.com/apache/maven-site/pull/449#issuecomment-1732337206

   Just FYI I did for myself a "note" (w/ commands to run) reminder, maybe is good to have them on this page as well? 
   https://github.com/apache/maven-indexer/blob/master/RELEASE.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] olamy commented on a diff in pull request #449: Improvements to release procedure

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #449:
URL: https://github.com/apache/maven-site/pull/449#discussion_r1326967875


##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -60,6 +62,38 @@ Performing a Maven Project Release
   If the item you are planning to release is not using the most recent version of its parent
   (see {{{../../pom/}parent POMs}} index), consider taking this opportunity to update to it.
 
+* Consider updating the project dependencies
+
+  Generally it is a good that project use tha latest available versions of used dependencies.
+
+* Prepare release notes
+
+ * check all commits since latest release, all mentioned issue should be connected with release notes
+
+ * all issues should be fixed and <<CLOSED>>
+
+ * all issues should be <<assigned>> to responsible person, which fixed or merged fix
+
+ * check existing issues with <<Blocker>> priority, consider to fix it or change priority if reasonable
+
+ []
+
+** Check release note at GitHub
+
+  If a component has a history of release notes at <<GitHub>>, we should to continue maintain it in order to avoid user confusing.
+
+  We can maintain release notes at <<GitHub>>, by one of:
+
+  * use release-drafter to help prepare release notes - in such case all PRs should a proper label

Review Comment:
   just look at this https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.11.0
   each PR have an appropriate label/category so there are ordered 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] hgschmie commented on a diff in pull request #449: Improvements to release procedure

Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie commented on code in PR #449:
URL: https://github.com/apache/maven-site/pull/449#discussion_r1326591031


##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -60,6 +62,38 @@ Performing a Maven Project Release
   If the item you are planning to release is not using the most recent version of its parent
   (see {{{../../pom/}parent POMs}} index), consider taking this opportunity to update to it.
 
+* Consider updating the project dependencies
+
+  Generally it is a good that project use tha latest available versions of used dependencies.
+
+* Prepare release notes
+
+ * check all commits since latest release, all mentioned issue should be connected with release notes
+
+ * all issues should be fixed and <<CLOSED>>
+
+ * all issues should be <<assigned>> to responsible person, which fixed or merged fix

Review Comment:
   change the order? assign first, then close? 



##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -60,6 +62,38 @@ Performing a Maven Project Release
   If the item you are planning to release is not using the most recent version of its parent
   (see {{{../../pom/}parent POMs}} index), consider taking this opportunity to update to it.
 
+* Consider updating the project dependencies
+
+  Generally it is a good that project use tha latest available versions of used dependencies.
+
+* Prepare release notes
+
+ * check all commits since latest release, all mentioned issue should be connected with release notes
+
+ * all issues should be fixed and <<CLOSED>>
+
+ * all issues should be <<assigned>> to responsible person, which fixed or merged fix
+
+ * check existing issues with <<Blocker>> priority, consider to fix it or change priority if reasonable
+
+ []
+
+** Check release note at GitHub
+
+  If a component has a history of release notes at <<GitHub>>, we should to continue maintain it in order to avoid user confusing.
+
+  We can maintain release notes at <<GitHub>>, by one of:
+
+  * use release-drafter to help prepare release notes - in such case all PRs should a proper label

Review Comment:
   example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-site] slawekjaranowski merged pull request #449: Improvements to release procedure

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #449:
URL: https://github.com/apache/maven-site/pull/449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org