You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/04/07 21:03:00 UTC

[GitHub] [daffodil] jadams-tresys opened a new pull request #524: Updated test to check for both '.' or ','

jadams-tresys opened a new pull request #524:
URL: https://github.com/apache/daffodil/pull/524


   Using the following settings:
   
   export SBT_OPTS="-Xss2M -Xmx5G -Xms5G -Duser.country=DE
   -Duser.language=de"
   
   Results in floating point numbers using a ',' instead of a '.' (ie.
   '3,0' instead of '3.0'. Updated test to use a regex to check for both
   symbols.
   
   DAFFODIL-2492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] jadams-tresys merged pull request #524: Updated test to check for both '.' or ','

Posted by GitBox <gi...@apache.org>.

jadams-tresys merged pull request #524:
URL: https://github.com/apache/daffodil/pull/524


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] jadams-tresys commented on pull request #524: Updated test to check for both '.' or ','

Posted by GitBox <gi...@apache.org>.

jadams-tresys commented on pull request #524:
URL: https://github.com/apache/daffodil/pull/524#issuecomment-815830320


   I think you are right Steve, we definitely could use some recurring locale testing as I could definitely see this sort of things continuing to pop up in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence commented on pull request #524: Updated test to check for both '.' or ','

Posted by GitBox <gi...@apache.org>.

stevedlawrence commented on pull request #524:
URL: https://github.com/apache/daffodil/pull/524#issuecomment-815741099


   +1
   
   Would it be worth creating a ticket to modify our GitHub actions so one or two of the jobs runs with a different locale so we can automate a bit of this testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org