You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/09/03 21:32:59 UTC
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request
#441: Fix the illegal state check
rdblue commented on a change in pull request #441: Fix the illegal state check
URL: https://github.com/apache/incubator-iceberg/pull/441#discussion_r320487710
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ColumnarBatchReader.java
##########
@@ -45,9 +45,11 @@ public final ColumnarBatch read(ColumnarBatch ignore) {
FieldVector vec = readers[i].read();
arrowVectorArr[i] = new ArrowColumnVector(vec);
- Preconditions.checkState(i > 0 && numRows == vec.getValueCount(),
+ if (i > 0) {
Review comment:
Isn't this just `Preconditions.checkState(i > 0 || numRows == vec.getValueCount(), ...)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org