[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6354: INSERT returns number of rows written, add `InsertExec` to handle common case.

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6354:
URL: https://github.com/apache/arrow-datafusion/pull/6354#discussion_r1194068923


##########
datafusion/core/src/datasource/memory.rs:
##########
@@ -480,8 +512,8 @@ mod tests {
 
         // Execute the physical plan and collect the results
         let res = collect(plan, session_ctx.task_ctx()).await?;
-        // Ensure the result is empty after the insert operation
-        assert!(res.is_empty());
+        assert_eq!(extract_count(res), expected_count);

Review Comment:
   here is the test for the new feature of returning row counts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org