You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/03 03:22:21 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #7210: revert: bignumber patch to prevent rendering regression in charts

codecov-io edited a comment on issue #7210: revert: bignumber patch to prevent rendering regression in charts
URL: https://github.com/apache/incubator-superset/pull/7210#issuecomment-479298289
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=h1) Report
   > Merging [#7210](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/200efacc3649d10a56ae14724d9b522a44839fe0?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7210/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           lyftga   #7210      +/-   ##
   =========================================
   - Coverage    64.5%   64.5%   -0.01%     
   =========================================
     Files         424     423       -1     
     Lines       20667   20651      -16     
     Branches     2268    2264       -4     
   =========================================
   - Hits        13332   13321      -11     
   + Misses       7212    7207       -5     
     Partials      123     123
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `7.57% <ø> (+0.53%)` | :arrow_up: |
   | [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `70.64% <100%> (+0.29%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=footer). Last update [200efac...5b73a9c](https://codecov.io/gh/apache/incubator-superset/pull/7210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org