You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Juan José Ramos Cassella (JIRA)" <ji...@apache.org> on 2018/10/19 07:52:00 UTC

[jira] [Resolved] (GEODE-5739) Server and LocatorStarter Rules should use respective Launchers

     [ https://issues.apache.org/jira/browse/GEODE-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juan José Ramos Cassella resolved GEODE-5739.
---------------------------------------------
    Resolution: Won't Fix

Looks like there's enough consent in that the JIRA must not be fixed (see this [discussion|https://github.com/apache/geode/pull/2604]).

> Server and LocatorStarter Rules should use respective Launchers
> ---------------------------------------------------------------
>
>                 Key: GEODE-5739
>                 URL: https://issues.apache.org/jira/browse/GEODE-5739
>             Project: Geode
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Jason Huynh
>            Assignee: Juan José Ramos Cassella
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In a review, it was mentioned from that we can change ServerStarterRule and LocatorStarterRule to use ServerLauncher and LocatorLauncher.
> This way the rules are using the User API directly. The Launchers are in-process APIs so they don't launch/fork new JVMs, they simply launch a Server or a Locator. The APIs also include stopping and this stopMember() method could then simply invoke serverLauncher.stop().
> PS: The forking of Server/Locator JVMs is performed by GFSH, not by these Launcher classes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)