You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/09/03 20:15:44 UTC

[jira] Created: (THRIFT-130) Remove optional read or write framing from TFramedTransport

Remove optional read or write framing from TFramedTransport
-----------------------------------------------------------

                 Key: THRIFT-130
                 URL: https://issues.apache.org/jira/browse/THRIFT-130
             Project: Thrift
          Issue Type: Improvement
          Components: Library (Java)
            Reporter: Bryan Duxbury
            Assignee: Bryan Duxbury
            Priority: Minor


It doesn't appear that anyone is using the optional read or write framing in TFramedTransport. It doesn't even really make that much sense. We should get rid of it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-130) Remove optional read or write framing from TFramedTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-130.
--------------------------------

    Resolution: Fixed

> Remove optional read or write framing from TFramedTransport
> -----------------------------------------------------------
>
>                 Key: THRIFT-130
>                 URL: https://issues.apache.org/jira/browse/THRIFT-130
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-130.patch
>
>
> It doesn't appear that anyone is using the optional read or write framing in TFramedTransport. It doesn't even really make that much sense. We should get rid of it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-130) Remove optional read or write framing from TFramedTransport

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-130:
---------------------------------

    Patch Info: [Patch Available]

> Remove optional read or write framing from TFramedTransport
> -----------------------------------------------------------
>
>                 Key: THRIFT-130
>                 URL: https://issues.apache.org/jira/browse/THRIFT-130
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-130.patch
>
>
> It doesn't appear that anyone is using the optional read or write framing in TFramedTransport. It doesn't even really make that much sense. We should get rid of it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-130) Remove optional read or write framing from TFramedTransport

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-130:
---------------------------------

    Attachment: thrift-130.patch

Here's a patch that removes the optional constructors and the checks for the flags within all the methods.

> Remove optional read or write framing from TFramedTransport
> -----------------------------------------------------------
>
>                 Key: THRIFT-130
>                 URL: https://issues.apache.org/jira/browse/THRIFT-130
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-130.patch
>
>
> It doesn't appear that anyone is using the optional read or write framing in TFramedTransport. It doesn't even really make that much sense. We should get rid of it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.