You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cramja <gi...@git.apache.org> on 2016/11/17 22:56:21 UTC
[GitHub] incubator-quickstep pull request #139: Remove packedrow
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/139
Remove packedrow
When I refactored the SplitRowStore to handle partial inserts, I optimized the bulk insert algorithm to efficiently handle inserts where attributes are all fixed length. There is almost no difference between the runtime of SSB/TPCH with/without the packed row store. So, in the interest of keeping simple code, I've removed the now unnecessary `splitrowstore`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cramja/incubator-quickstep remove_packedrow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #139
----
commit 2e01cf8369ca4c660852cc266270338699813129
Author: cramja <ma...@gmail.com>
Date: 2016-11-07T19:33:21Z
Remove PackedRowStoreBlock
commit 60eda732be713bb75ef71715aa9a67a4373e1ddb
Author: cramja <ma...@gmail.com>
Date: 2016-11-17T20:16:50Z
Removes packed row store.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #139: Remove packedrow
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/139
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #139: Remove packedrow
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/139
Hi @cramja - Sure, we can close this PR. Looks like Travis is failing right now and the issue is not the OOM error we saw in some of the previous PRs. Once you fix the issues, please let me know. I can take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #139: Remove packedrow
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/139
@hbdeshmukh I fixed the problem, hopefully. Waiting for Travis to come back.
There's several Travis runs which I triggered (`git commit --amend; git push --force`) while testing. Did travis remove the kill build feature? I seem to remember being able to kill these sorts of things in the past by logging into their site...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #139: Remove packedrow
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/139
@hbdeshmukh my new years resolution is to finish this PR. Want to review this with me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #139: Remove packedrow
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---