You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/04/29 01:59:44 UTC

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22828


Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................

IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

TestEventSyncWaiting depends on running statements on Hive which doesn't
work in non-HDFS builds. This patch skips the test in these builds.

Change-Id: I947ad23456c01bc76df0ad154519360549143b80
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/22828/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22828 )

Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................

IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

TestEventSyncWaiting depends on running statements on Hive which doesn't
work in non-HDFS builds. This patch skips the test in these builds.

Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Reviewed-on: http://gerrit.cloudera.org:8080/22828
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22828 )

Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Apr 2025 09:21:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22828 )

Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Apr 2025 02:45:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22828 )

Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19045/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Apr 2025 02:26:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22828 )

Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11809/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Apr 2025 02:58:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22828 )

Change subject: IMPALA-13974: (Addendum) Skip TestEventSyncWaiting in non-HDFS builds
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I947ad23456c01bc76df0ad154519360549143b80
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Apr 2025 02:58:22 +0000
Gerrit-HasComments: No