You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/07/28 06:58:27 UTC
[kudu-CR] [master-test] clean up CreateTable() signature
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17734
Change subject: [master-test] clean up CreateTable() signature
......................................................................
[master-test] clean up CreateTable() signature
This patch changes the signatures of the overloaded CreateTable()
methods to better fit the existing test scenarios. With that, the
call sites have less arguments to supply.
This changlist doesn't contain any functional modifications.
Change-Id: I78aebc17451c3dfa0a88edae9353a597053f2f72
---
M src/kudu/master/master-test.cc
1 file changed, 160 insertions(+), 124 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/17734/1
--
To view, visit http://gerrit.cloudera.org:8080/17734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78aebc17451c3dfa0a88edae9353a597053f2f72
Gerrit-Change-Number: 17734
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master-test] clean up CreateTable() signature
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17734 )
Change subject: [master-test] clean up CreateTable() signature
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78aebc17451c3dfa0a88edae9353a597053f2f72
Gerrit-Change-Number: 17734
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 07:24:58 +0000
Gerrit-HasComments: No
[kudu-CR] [master-test] clean up CreateTable() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17734 )
Change subject: [master-test] clean up CreateTable() signature
......................................................................
[master-test] clean up CreateTable() signature
This patch changes the signatures of the overloaded CreateTable()
methods to better fit the existing test scenarios. With that, the
call sites have less arguments to supply.
This changlist doesn't contain any functional modifications.
Change-Id: I78aebc17451c3dfa0a88edae9353a597053f2f72
Reviewed-on: http://gerrit.cloudera.org:8080/17734
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master-test.cc
1 file changed, 160 insertions(+), 124 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78aebc17451c3dfa0a88edae9353a597053f2f72
Gerrit-Change-Number: 17734
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>