You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "TOTON95 (via GitHub)" <gi...@apache.org> on 2024/08/13 04:54:36 UTC
[PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
TOTON95 opened a new pull request, #12902:
URL: https://github.com/apache/nuttx/pull/12902
Targets: Devices using `arm/stm32h7x3x_rcc.c`
## Summary
This adds the option of using an external power supply connected directly to the VCAP pin.
This is necessary if the board designer decides to power the uC through an external power supply, which can help to decrease the temperature, have a stable current delivery, etc.
I kept this modification as simple as possible, so further combinations could be applied as shown in the reference manual RM0399, pages 275 and 329. It also is adapted to requirements shown in RM0433, pages 260 and 307.
## Impact
This should have minimal or lack of any impact on present targets, as it's using a new setting built around the existing power options structure, keeping the current configurations untouched.
## Testing
- Checked correct compilation against `nucleo-h743zi` and `stm32h747i-disco` targets, modifying the configuration of settings involved.
- Tested in HW with downstream (PX4) using 3DR Control Zero H7 OEM rev G.
Feedback is always welcomed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "TOTON95 (via GitHub)" <gi...@apache.org>.
TOTON95 commented on code in PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#discussion_r1717154545
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -296,6 +296,8 @@ config STM32H7_PWR_DIRECT_SMPS_SUPPLY
config STM32H7_PWR_EXTERNAL_SOURCE_SUPPLY
bool "Use external source as power supply"
default n
+ ---help---
Review Comment:
@acassis Fixed 🙌🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on code in PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#discussion_r1715124365
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -293,6 +293,10 @@ config STM32H7_PWR_DIRECT_SMPS_SUPPLY
depends on STM32H7_HAVE_SMPS
default n
+config STM32H7_PWR_EXTERNAL_SOURCE_SUPPLY
+ bool "Use external source as power supply"
+ default n
+
Review Comment:
Please add help 'Select this option for using an external power supply connected directly to the VCAP pin.'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "TOTON95 (via GitHub)" <gi...@apache.org>.
TOTON95 commented on PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#issuecomment-2289611989
@xiaoxiang781216 @acassis @davids5 Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#discussion_r1715804119
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -296,6 +296,8 @@ config STM32H7_PWR_DIRECT_SMPS_SUPPLY
config STM32H7_PWR_EXTERNAL_SOURCE_SUPPLY
bool "Use external source as power supply"
default n
+ ---help---
Review Comment:
Kconfig uses TAB instead of spaces, please fix. Also squash the commits: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "TOTON95 (via GitHub)" <gi...@apache.org>.
TOTON95 commented on code in PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#discussion_r1715786661
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -293,6 +293,10 @@ config STM32H7_PWR_DIRECT_SMPS_SUPPLY
depends on STM32H7_HAVE_SMPS
default n
+config STM32H7_PWR_EXTERNAL_SOURCE_SUPPLY
+ bool "Use external source as power supply"
+ default n
+
Review Comment:
@davids5 No problem, it's now added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "TOTON95 (via GitHub)" <gi...@apache.org>.
TOTON95 commented on PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#issuecomment-2287969180
@xiaoxiang781216 My bad, I just squashed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12902:
URL: https://github.com/apache/nuttx/pull/12902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#discussion_r1715804119
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -296,6 +296,8 @@ config STM32H7_PWR_DIRECT_SMPS_SUPPLY
config STM32H7_PWR_EXTERNAL_SOURCE_SUPPLY
bool "Use external source as power supply"
default n
+ ---help---
Review Comment:
Kconfig use TAB instead of spaces, please fix. Also squash the commits: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/stm32h7x3x_rcc.c: Add External Power Supply option to stm32h7x3x … [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #12902:
URL: https://github.com/apache/nuttx/pull/12902#issuecomment-2287536925
@TOTON95 please squash your change into one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org