You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/03/26 21:04:31 UTC
[GitHub] nitin-maharana commented on a change in pull request #2512: Only use the host if its Resource State is Enabled.
nitin-maharana commented on a change in pull request #2512: Only use the host if its Resource State is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#discussion_r177234196
##########
File path: engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
##########
@@ -484,7 +483,7 @@ else if (volumeInfo.getFormat() == ImageFormat.OVA || volumeInfo.getFormat() ==
}
SnapshotResult result = null;
- SnapshotInfo snapshotOnPrimary = null;
+ SnapshotInfo snapshotOnPrimary;
Review comment:
I guess the removal of this may create NPE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services