You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/08/04 22:01:00 UTC
[jira] [Commented] (IMPALA-7394) Don't print stack trace in
ImpalaServer::ExpireSessions()
[ https://issues.apache.org/jira/browse/IMPALA-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569302#comment-16569302 ]
ASF subversion and git services commented on IMPALA-7394:
---------------------------------------------------------
Commit 34fd9732e6fa66c7eec41317bbec3486063559eb in impala's branch refs/heads/master from Michael Ho
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=34fd973 ]
IMPALA-7394: Don't print stack trace in ExpireSessions()
When sessions expire, ExpireSessions() may create excessive amount
of log spew due to printing of the stack traces esp when there are
a massive amount of sessions expiring at the same time. This stack
crawling also unnecessarily extends the critical section under the
session_state_map_lock_, increasing the contention for that lock.
This change converts the use of Status() to Status::Expected() to
remove the unnecessary stack crawl.
Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Reviewed-on: http://gerrit.cloudera.org:8080/11117
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Don't print stack trace in ImpalaServer::ExpireSessions()
> ----------------------------------------------------------
>
> Key: IMPALA-7394
> URL: https://issues.apache.org/jira/browse/IMPALA-7394
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.0, Impala 2.12.0
> Reporter: Michael Ho
> Assignee: Michael Ho
> Priority: Minor
>
> It appears that session expiration can result in huge amount of log spew like the following. While IMPALA-7014 reduces the overhead by avoiding the symbolization, the log spew still seems unnecessary.
> {noformat}
> I0730 13:00:10.241578 400820 status.cc:125] Session expired due to inactivity
> @ 0x96678a impala::Status::Status()
> @ 0xc00d3c impala::ImpalaServer::ExpireSessions()
> @ 0xd6101f impala::Thread::SuperviseThread()
> @ 0xd6181a boost::detail::thread_data<>::run()
> @ 0x12d85ca (unknown)
> @ 0x7f16285fbdc5 start_thread
> @ 0x7f162832c17d __clone
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org