You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/07/20 16:32:00 UTC

[jira] [Commented] (PHOENIX-5974) RequestId for Phoenix Query

    [ https://issues.apache.org/jira/browse/PHOENIX-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384380#comment-17384380 ] 

ASF GitHub Bot commented on PHOENIX-5974:
-----------------------------------------

abhishek-chouhan commented on pull request #1250:
URL: https://github.com/apache/phoenix/pull/1250#issuecomment-883531385


   Have we looked at the scanId that we already have in BaseResultIterators? Seems to be scarcely used. However, we would want to have a single notion of a queryId, unless needed otherwise.
   
   It also looks like the clients need to set this explicitly? Ideally we would not want the clients going through the internal implementations of phoenix (PhoenixStatement and their derivates in this case). Having phoenix generate the queryId implicitly makes more sense IMO.
   
   The notion also seems useful not only for tracing but also for debugging. At the moment, logging in phoenix is scattered and hard to correlate with the actual query. @ArkenKiran 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> RequestId for Phoenix Query
> ---------------------------
>
>                 Key: PHOENIX-5974
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5974
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Pranshu Khandelwal
>            Assignee: Kiran Kumar Maturi
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add a TraceId corresponding to a Phoenix Query which translates further into an HBase mutationId. Using this TraceId one can log information about the bottlenecks in the Network and Trace out the flow of the SQL like Phoenix Query till it compiles as an Hbase mutation and ultimately into a Message to the RPC Layer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)