You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/02/16 21:21:53 UTC
Review Request 43620: Added stat to know time spent in handover udp
message to other executor pool
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43620/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
Repository: geode
Description
-------
Added stat to know time spent in handover udp message to other executor pool
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java 7bf5b80
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 28ca380
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 419c096
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 3bd1e83
Diff: https://reviews.apache.org/r/43620/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 43620: Added stat to know time spent in handover
udp message to other executor pool
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43620/#review119494
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On Feb. 16, 2016, 8:21 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43620/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 8:21 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added stat to know time spent in handover udp message to other executor pool
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java 7bf5b80
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 28ca380
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 419c096
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 3bd1e83
>
> Diff: https://reviews.apache.org/r/43620/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 43620: Added stat to know time spent in handover
udp message to other executor pool
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43620/#review119496
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On Feb. 16, 2016, 8:21 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43620/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 8:21 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added stat to know time spent in handover udp message to other executor pool
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java 7bf5b80
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 28ca380
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 419c096
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 3bd1e83
>
> Diff: https://reviews.apache.org/r/43620/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 43620: Added stat to know time spent in handover
udp message to other executor pool
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43620/#review119356
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java (line 276)
<https://reviews.apache.org/r/43620/#comment180670>
I think you should say that it includes the time to deserialize the message. Something like this:
The total amount of time spent deserializing and dispatching UDP messages in the message-reader thread.
- Bruce Schuchardt
On Feb. 16, 2016, 8:21 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43620/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 8:21 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added stat to know time spent in handover udp message to other executor pool
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java 7bf5b80
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 28ca380
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 419c096
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 3bd1e83
>
> Diff: https://reviews.apache.org/r/43620/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 43620: Added stat to know time spent in handover
udp message to other executor pool
Posted by Karen Miller <km...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43620/#review119527
-----------------------------------------------------------
Please change the spelling of every string and variable name that currently embeds (incorrect) 'dispach.' The correct spelling is dispatch (with a 't').
- Karen Miller
On Feb. 16, 2016, 8:21 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43620/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 8:21 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added stat to know time spent in handover udp message to other executor pool
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java 7bf5b80
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 28ca380
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 419c096
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 3bd1e83
>
> Diff: https://reviews.apache.org/r/43620/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>