You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "Searion (via GitHub)" <gi...@apache.org> on 2026/01/30 03:53:34 UTC
[PR] fix build error when protobuf version is 4.24 by adjusting protobuf version check (brpc)
Searion opened a new pull request, #3209:
URL: https://github.com/apache/brpc/pull/3209
### What problem does this PR solve?
Issue Number: resolve [3208](https://github.com/apache/brpc/issues/3208)
Problem Summary:
error: 'const class google::protobuf::Descriptor::ExtensionRange' has no member named 'start'
in src/json2pb/json_to_pb.cpp / src/json2pb/pb_to_json.cpp
### What is changed and the side effects?
Changed: protobuf version check in in src/json2pb/json_to_pb.cpp / src/json2pb/pb_to_json.cpp
in protobuf 4.xx version, start is deprecated and should be replaced. The old condition
>= 4.25 version is not right
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix build error when protobuf version is 4.24 by adjusting protobuf version check (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3209:
URL: https://github.com/apache/brpc/pull/3209#issuecomment-3827660731
The issue was fixed by https://github.com/apache/brpc/pull/3210, so I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix build error when protobuf version is 4.24 by adjusting protobuf version check (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3209:
URL: https://github.com/apache/brpc/pull/3209#issuecomment-3821724050
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix build error when protobuf version is 4.24 by adjusting protobuf version check (brpc)
Posted by "yanglimingcn (via GitHub)" <gi...@apache.org>.
yanglimingcn commented on PR #3209:
URL: https://github.com/apache/brpc/pull/3209#issuecomment-3822057559
It appears to have changed starting from 4024000.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix build error when protobuf version is 4.24 by adjusting protobuf version check (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm closed pull request #3209: fix build error when protobuf version is 4.24 by adjusting protobuf version check
URL: https://github.com/apache/brpc/pull/3209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org