You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/19 09:34:39 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5544: Fix of revert RBD snapshots

GabrielBrascher commented on a change in pull request #5544:
URL: https://github.com/apache/cloudstack/pull/5544#discussion_r752992628



##########
File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -1327,32 +1322,11 @@ private void updateSnapshotPayload(long storagePoolId, CreateSnapshotPayload pay
     }
 
     private DataStoreRole getDataStoreRole(Snapshot snapshot, SnapshotDataStoreDao snapshotStoreDao, DataStoreManager dataStoreMgr) {

Review comment:
       The `dataStoreMgr` will not be used, it would be better to remove it from the method signature.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org