You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/28 03:23:17 UTC
[GitHub] [hudi] nsivabalan commented on a change in pull request #3147: [HUDI-1983] [DOC]Add key gen type config to Configurations page in hudi we…
nsivabalan commented on a change in pull request #3147:
URL: https://github.com/apache/hudi/pull/3147#discussion_r659453008
##########
File path: docs/_docs/2_4_configurations.md
##########
@@ -83,8 +83,12 @@ Actual value ontained by invoking .toString()</span>
#### KEYGENERATOR_CLASS_OPT_KEY {#KEYGENERATOR_CLASS_OPT_KEY}
Property: `hoodie.datasource.write.keygenerator.class`, Default: `org.apache.hudi.keygen.SimpleKeyGenerator` <br/>
- <span style="color:grey">Key generator class, that implements will extract the key out of incoming `Row` object</span>
-
+ <span style="color:grey">Key generator class, that implements will extract the key out of incoming `Row` object. This config option is used for user-defined KeyGenerator</span>
Review comment:
Can you also add a line there, that this has higher precedence over keygen type.
##########
File path: docs/_docs/2_4_configurations.md
##########
@@ -83,8 +83,12 @@ Actual value ontained by invoking .toString()</span>
#### KEYGENERATOR_CLASS_OPT_KEY {#KEYGENERATOR_CLASS_OPT_KEY}
Property: `hoodie.datasource.write.keygenerator.class`, Default: `org.apache.hudi.keygen.SimpleKeyGenerator` <br/>
- <span style="color:grey">Key generator class, that implements will extract the key out of incoming `Row` object</span>
-
+ <span style="color:grey">Key generator class, that implements will extract the key out of incoming `Row` object. This config option is used for user-defined KeyGenerator</span>
Review comment:
also, there is no more default for hoodie.datasource.write.keygenerator.class if I understand correctly. can we fix that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org