[jira] [Commented] (KNOX-792) Fix FindBugs "performance" issues

["Colm O hEigeartaigh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728668#comment-15728668 ] 

Colm O hEigeartaigh commented on KNOX-792:
------------------------------------------

Hi [~lmccay],

Thanks for the feedback! 

I decided to address just the bugs that were grouped under "Performance" in the Findbugs report just to keep the patch manageable for this JIRA. So the fixes that were included were for the rules:

a) Inefficient map iterator
b) Inner class should be made static
c) Unread field
d) Questionable boxing of primitive value
e) String concatenation in loop using + operator

Taking your comments into consideration I propose amending the patch as follows:

a) Only make inner classes static if they are private (actually most of the changes). This won't have any existing implications as they are private, and can always be made non-static in the future if required. 
As you noted it may not have much impact on performance, but I guess it doesn't hurt to make them static. If you object I'll take this out.

b) Scrap the target audience changes in WebSSOResource and create a new JIRA for this, as it appears to be a bug as you pointed out

c) Leave the rest of the changes in, they're fairly self-evident I think.

Thoughts?

Colm.


> Fix FindBugs "performance" issues
> ---------------------------------
>
>                 Key: KNOX-792
>                 URL: https://issues.apache.org/jira/browse/KNOX-792
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Trivial
>             Fix For: 0.11.0
>
>         Attachments: 0001-KNOX-702-Fix-FindBugs-performance-issues.patch
>
>
> This task is to fix the "performance" issues identified by findbugs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)