You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Tony Poppleton (JIRA)" <ji...@apache.org> on 2010/01/16 23:31:55 UTC
[jira] Created: (HTTPCORE-216) Custom implementation of parseInt
and Integer.toString
Custom implementation of parseInt and Integer.toString
------------------------------------------------------
Key: HTTPCORE-216
URL: https://issues.apache.org/jira/browse/HTTPCORE-216
Project: HttpComponents HttpCore
Issue Type: Sub-task
Reporter: Tony Poppleton
Priority: Minor
The parent task shows that a hot spot is the CharArrayBuffer.substringTrimmed method, and in a number of places it is only called to be able to parse an integer from the buffer using the Integer.parseInt(String str) method in the Jave libraries.
This is a generalization of one of the patches in HTTPCORE-212 that was just addressing this issue in one place.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCORE-216) Custom implementation of parseInt
and Integer.toString
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841933#action_12841933 ]
Oleg Kalnichevski commented on HTTPCORE-216:
--------------------------------------------
Tony,
Are you still interested in working on this issue or shall I close it as WONTFIX?
There are benchmarks you could use to measure the impact of your changes on HttpCore performance
http://wiki.apache.org/HttpComponents/HttpCoreBenchmark
http://wiki.apache.org/HttpComponents/HttpClient3vsHttpClient4vsHttpCore
Oleg
> Custom implementation of parseInt and Integer.toString
> ------------------------------------------------------
>
> Key: HTTPCORE-216
> URL: https://issues.apache.org/jira/browse/HTTPCORE-216
> Project: HttpComponents HttpCore
> Issue Type: Sub-task
> Reporter: Tony Poppleton
> Priority: Minor
> Fix For: 4.1-beta1
>
>
> The parent task shows that a hot spot is the CharArrayBuffer.substringTrimmed method, and in a number of places it is only called to be able to parse an integer from the buffer using the Integer.parseInt(String str) method in the Jave libraries.
> This is a generalization of one of the patches in HTTPCORE-212 that was just addressing this issue in one place.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCORE-216) Custom implementation of parseInt
and Integer.toString
Posted by "Tony Poppleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Poppleton resolved HTTPCORE-216.
-------------------------------------
Resolution: Won't Fix
Closing as won't fix.
I have made such extensive changes to my own version of the library that I know that a patch won't be accepted. FWIW there is a small speedup to be had by doing these changes, although the biggest impact is in reducing the GC overhead and making it more deterministic, but my changes are not worth it for the general codebase as it makes it a lot less readable.
> Custom implementation of parseInt and Integer.toString
> ------------------------------------------------------
>
> Key: HTTPCORE-216
> URL: https://issues.apache.org/jira/browse/HTTPCORE-216
> Project: HttpComponents HttpCore
> Issue Type: Sub-task
> Reporter: Tony Poppleton
> Priority: Minor
> Fix For: 4.1-beta1
>
>
> The parent task shows that a hot spot is the CharArrayBuffer.substringTrimmed method, and in a number of places it is only called to be able to parse an integer from the buffer using the Integer.parseInt(String str) method in the Jave libraries.
> This is a generalization of one of the patches in HTTPCORE-212 that was just addressing this issue in one place.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org