You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/11/21 03:25:40 UTC
Review Request 28311: Upgrade Execute: implement proper RESTART
commands
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
Bugs: AMBARI-8406
https://issues.apache.org/jira/browse/AMBARI-8406
Repository: ambari
Description
-------
Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
Diff: https://reviews.apache.org/r/28311/diff/
Testing
-------
test results pending
Thanks,
Nate Cole
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62600
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 2:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 21, 2014, 7:47 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 574
> > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574>
> >
> > is it intended to have such value for a cluster name?
>
> Dmitro Lisnichenko wrote:
> Also, I have almost the same code for creating a stage for distribute repos/install packages and sending a custom action to all hosts. How about moving this createRestartStage() method somewhere to helper class so I can generify and reuse it?
>
> Nate Cole wrote:
> Let's discuss. Not sure why distribute/install requires a restart. Firing a single custom action that is not a restart is pretty straightforward.
>
> Dmitro Lisnichenko wrote:
> Since different hosts with different service components installed have different package sets, we have to send individual install_packages custom action to every host. In order to let multiple custom actions to execute in parallel, we either have to bind them to different requests or put them all into a single stage.
It's only semantics about how the work gets done. For now put them all in a single request with a single stage. Even on a cluster with 1000 hosts, we still need 1000 units of work done.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62541
-----------------------------------------------------------
On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:43 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Nov. 21, 2014, 12:47 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 574
> > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574>
> >
> > is it intended to have such value for a cluster name?
Also, I have almost the same code for creating a stage for distribute repos/install packages and sending a custom action to all hosts. How about moving this createRestartStage() method somewhere to helper class so I can generify and reuse it?
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62541
-----------------------------------------------------------
On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 2:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Nate Cole <nc...@hortonworks.com>.
> On Nov. 21, 2014, 7:47 a.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 574
> > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574>
> >
> > is it intended to have such value for a cluster name?
>
> Dmitro Lisnichenko wrote:
> Also, I have almost the same code for creating a stage for distribute repos/install packages and sending a custom action to all hosts. How about moving this createRestartStage() method somewhere to helper class so I can generify and reuse it?
Let's discuss. Not sure why distribute/install requires a restart. Firing a single custom action that is not a restart is pretty straightforward.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62541
-----------------------------------------------------------
On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:43 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Nov. 21, 2014, 12:47 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 574
> > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574>
> >
> > is it intended to have such value for a cluster name?
>
> Dmitro Lisnichenko wrote:
> Also, I have almost the same code for creating a stage for distribute repos/install packages and sending a custom action to all hosts. How about moving this createRestartStage() method somewhere to helper class so I can generify and reuse it?
>
> Nate Cole wrote:
> Let's discuss. Not sure why distribute/install requires a restart. Firing a single custom action that is not a restart is pretty straightforward.
Since different hosts with different service components installed have different package sets, we have to send individual install_packages custom action to every host. In order to let multiple custom actions to execute in parallel, we either have to bind them to different requests or put them all into a single stage.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62541
-----------------------------------------------------------
On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 2:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62541
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28311/#comment104599>
is it intended to have such value for a cluster name?
- Dmitro Lisnichenko
On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 2:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62538
-----------------------------------------------------------
Ship it!
Ship It!
- Yurii Shylov
On Ноя. 21, 2014, 2:43 д.п., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Ноя. 21, 2014, 2:43 д.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62537
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 2:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Nov. 21, 2014, 12:51 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 574
> > <https://reviews.apache.org/r/28311/diff/1/?file=771830#file771830line574>
> >
> > The second argument is not a cluster name, it's a log directory. It's apparently unused (and I don't even know why it's there in the first place, no one knows :) ). I'm working on having it removed.
Sorry, I checked parameter order without your patch applied. You are right.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62542
-----------------------------------------------------------
On Nov. 21, 2014, 2:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 2:43 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/#review62542
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
<https://reviews.apache.org/r/28311/#comment104600>
The second argument is not a cluster name, it's a log directory. It's apparently unused (and I don't even know why it's there in the first place, no one knows :) ). I'm working on having it removed.
- Nate Cole
On Nov. 20, 2014, 9:43 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28311/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:43 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
>
>
> Bugs: AMBARI-8406
> https://issues.apache.org/jira/browse/AMBARI-8406
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
>
> Diff: https://reviews.apache.org/r/28311/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:02.228s
> [INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
> [INFO] Final Memory: 30M/666M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 28311: Upgrade Execute: implement proper RESTART
commands
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28311/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 9:43 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii Shylov.
Bugs: AMBARI-8406
https://issues.apache.org/jira/browse/AMBARI-8406
Repository: ambari
Description
-------
Replace stub restart with an actual restart command. Needed a slight refactor to move required common code out of AMCI
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 4103621
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9d3a1f8
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteCommandJson.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 9138ec2
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java e068508
Diff: https://reviews.apache.org/r/28311/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:02.228s
[INFO] Finished at: Thu Nov 20 21:43:10 EST 2014
[INFO] Final Memory: 30M/666M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole