You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by gallenvara <gi...@git.apache.org> on 2016/04/26 18:18:09 UTC

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

GitHub user gallenvara opened a pull request:

    https://github.com/apache/flink/pull/1940

    [FLINK-2220] Join on Pojo without hashCode() silently fails

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    Add a check to verify the POJO has overridden the `hashCode()` and `equals()` where it used as a key for operations(join,coGroup,etc).
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gallenvara/flink flink-2220

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1940
    
----
commit 2f8bfe59540831f3e2e9b181f3a51f0565693cb2
Author: gallenvara <ga...@126.com>
Date:   2016-04-26T16:08:27Z

    Check hashcode and equal method overridden in which POJO used as key.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1940#issuecomment-216372861
  
    I added a comment to FLINK-2220. I think the original analysis of the problem was not correct. It is not necessary to check for POJOs whether they override `equals()` and `hashcode()`. Details in FLINK-2220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

Posted by gallenvara <gi...@git.apache.org>.

Github user gallenvara commented on the pull request:

    https://github.com/apache/flink/pull/1940#issuecomment-220316125
  
    @fhueske i can't reproduce the issue in another computer. And I'm not sure if it's because I forgot the default constructor (no parameter) that led to the problem existing. I sent email to the reporter and not responsed. I will close the PR. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1940#issuecomment-220310633
  
    Any update for this PR, @gallenvara?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2220] Join on Pojo without hashCode() s...

Posted by gallenvara <gi...@git.apache.org>.

Github user gallenvara closed the pull request at:

    https://github.com/apache/flink/pull/1940


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---