[GitHub] athanatos commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets

[GitBox <gi...@apache.org>]

athanatos commented on a change in pull request #993: PendingReadOp: improve logging for speculative read targets
URL: https://github.com/apache/bookkeeper/pull/993#discussion_r162139091
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
 ##########
 @@ -254,9 +255,10 @@ public String toString() {
                 @Override
                 public Boolean call() throws Exception {
                     if (!isComplete() && null != maybeSendSpeculativeRead(heardFromHostsBitSet)) {
-                        if (LOG.isDebugEnabled()) {
-                            LOG.debug("Send speculative read for {}. Hosts heard are {}, ensemble is {}.",
-                                    this, heardFromHostsBitSet, ensemble);
+                        if (LOG.isInfoEnabled()) {
 
 Review comment:
   It's been pretty useful for us.  Perhaps we should simply bump logging to debug in the few classes where we want it. @jvrao thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services