You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/06/02 17:00:16 UTC
[GitHub] incubator-brooklyn pull request: AutoScaler now takes config keys ...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/673
AutoScaler now takes config keys for iteration increment and iteration max...
e.g. to say increase in batches of 10, decrease in batches of 5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn autoscaler-increment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #673
----
commit 7be4e076a9aa84195a7887eee9585a508222a220
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-05-26T05:26:04Z
AutoScaler now takes config keys for iteration increment and iteration max
e.g. to say increase in batches of 10, decrease in batches of 5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: AutoScaler now takes config keys ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: AutoScaler now takes config keys ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/673#discussion_r31814675
--- Diff: policy/src/main/java/brooklyn/policy/autoscaling/AutoScalerPolicy.java ---
@@ -282,6 +305,35 @@ public ResizeOperator apply(final Closure closure) {
.reconfigurable(true)
.build();
+ @SetFromFlag("resizeUpIterationIncrement")
+ public static final ConfigKey<Integer> RESIZE_UP_ITERATION_INCREMENT = BasicConfigKey.builder(Integer.class)
+ .name("autoscaler.resizeUpIterationIncrement")
+ .description("Batch size for resizing up; the size will be increased by a mulitiple of this value")
--- End diff --
Typo: mulitiple
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: AutoScaler now takes config keys ...
Posted by ggrunin <gi...@git.apache.org>.
Github user ggrunin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/673#issuecomment-108131750
tested - looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: AutoScaler now takes config keys ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/673#discussion_r31814694
--- Diff: policy/src/main/java/brooklyn/policy/autoscaling/AutoScalerPolicy.java ---
@@ -282,6 +305,35 @@ public ResizeOperator apply(final Closure closure) {
.reconfigurable(true)
.build();
+ @SetFromFlag("resizeUpIterationIncrement")
+ public static final ConfigKey<Integer> RESIZE_UP_ITERATION_INCREMENT = BasicConfigKey.builder(Integer.class)
+ .name("autoscaler.resizeUpIterationIncrement")
+ .description("Batch size for resizing up; the size will be increased by a mulitiple of this value")
+ .defaultValue(1)
+ .reconfigurable(true)
+ .build();
+ @SetFromFlag("resizeUpIterationMax")
+ public static final ConfigKey<Integer> RESIZE_UP_ITERATION_MAX = BasicConfigKey.builder(Integer.class)
+ .name("autoscaler.resizeUpIterationMax")
+ .defaultValue(Integer.MAX_VALUE)
+ .description("Maximum change to the size on a single iteration when scaling up")
+ .reconfigurable(true)
+ .build();
+ @SetFromFlag("resizeDownIterationIncrement")
+ public static final ConfigKey<Integer> RESIZE_DOWN_ITERATION_INCREMENT = BasicConfigKey.builder(Integer.class)
+ .name("autoscaler.resizeDownIterationIncrement")
+ .description("Batch size for resizing down; the size will be decreased by a mulitiple of this value")
--- End diff --
Typo again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---