[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6029: [KVM] Disconnect the volumes with the proper storage adaptor.

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #6029:
URL: https://github.com/apache/cloudstack/pull/6029#discussion_r812833419



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ScaleIOStorageAdaptor.java
##########
@@ -214,12 +214,12 @@ public boolean disconnectPhysicalDisk(String volumePath, KVMStoragePool pool) {
 
     @Override
     public boolean disconnectPhysicalDisk(Map<String, String> volumeToDisconnect) {
-        return true;
+        return false;
     }
 
     @Override
     public boolean disconnectPhysicalDiskByPath(String localPath) {

Review comment:
       sounds correct. I am assuming you have tested the behaviour.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org