You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/23 15:39:13 UTC

[GitHub] [doris] morningman commented on a diff in pull request #13246: [Feature](runtime-filter) add runtime filter breaking change adapt

morningman commented on code in PR #13246:
URL: https://github.com/apache/doris/pull/13246#discussion_r1002729158


##########
be/src/vec/core/block.cpp:
##########
@@ -64,7 +64,14 @@ Block::Block(const std::vector<SlotDescriptor*>& slots, size_t block_size) {
 }
 
 Block::Block(const PBlock& pblock) {
-    CHECK(HeartbeatServer::check_be_exec_version(pblock.be_exec_version()));
+    int be_exec_version = 0;
+    if (pblock.has_be_exec_version()) {
+        be_exec_version = pblock.be_exec_version();
+    } else {
+        LOG(WARNING) << "pblock.has_be_exec_version()=false, maybe pblock not be serialized well, "

Review Comment:
   Agreed, remove this log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org