You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "liyamahendra (via GitHub)" <gi...@apache.org> on 2023/01/25 14:19:19 UTC
[GitHub] [cordova-common] liyamahendra opened a new pull request, #197: android: added monochrome attribute
liyamahendra opened a new pull request, #197:
URL: https://github.com/apache/cordova-common/pull/197
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Android 13 added support for Themed Icons. Since themed icons aren't yet supported on Cordova Android, adding support for Themed icons inside `cordova-android` required modification to this project as the former project uses `getStaticResources` function defined inside `cordova-common`
https://github.com/apache/cordova-android/issues/1450
### Description
<!-- Describe your changes in detail -->
Added support for parsing the monochrome icon for Android when preparing / updating the icons.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] codecov-commenter commented on pull request #197: android: added monochrome attribute
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #197:
URL: https://github.com/apache/cordova-common/pull/197#issuecomment-1403722418
# [Codecov](https://codecov.io/gh/apache/cordova-common/pull/197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#197](https://codecov.io/gh/apache/cordova-common/pull/197?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f415cf) into [master](https://codecov.io/gh/apache/cordova-common/commit/cc78c8190a7adcfac701d68c51fdae3fa17e665c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc78c81) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 88.38% 88.39% +0.01%
==========================================
Files 20 20
Lines 1145 1146 +1
==========================================
+ Hits 1012 1013 +1
Misses 133 133
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/ConfigParser/ConfigParser.js](https://codecov.io/gh/apache/cordova-common/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL0NvbmZpZ1BhcnNlci9Db25maWdQYXJzZXIuanM=) | `85.45% <100.00%> (+0.08%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] liyamahendra closed pull request #197: android: added monochrome attribute
Posted by "liyamahendra (via GitHub)" <gi...@apache.org>.
liyamahendra closed pull request #197: android: added monochrome attribute
URL: https://github.com/apache/cordova-common/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] liyamahendra commented on pull request #197: android: added monochrome attribute
Posted by "liyamahendra (via GitHub)" <gi...@apache.org>.
liyamahendra commented on PR #197:
URL: https://github.com/apache/cordova-common/pull/197#issuecomment-1404055723
@erisu Oh! I accidentally closed it thinking it was merged. But I was wrong, it was only approved. I don't have permissions to reopen it, maybe someone with permissions can do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu commented on pull request #197: android: added monochrome attribute
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #197:
URL: https://github.com/apache/cordova-common/pull/197#issuecomment-1403754191
Why was this PR closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-common] erisu merged pull request #197: android: added monochrome attribute
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #197:
URL: https://github.com/apache/cordova-common/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org