You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by oxygen311 <gi...@git.apache.org> on 2018/07/03 12:15:17 UTC

[GitHub] zeppelin pull request #3049: [ZEPPELIN-3580]

GitHub user oxygen311 opened a pull request:

    https://github.com/apache/zeppelin/pull/3049

    [ZEPPELIN-3580]

    ### What is this PR for?
    Adds rename note method to rest api
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    issue on Jira: https://issues.apache.org/jira/browse/ZEPPELIN-3580

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3585

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3049
    
----
commit ad880ed31d6158a5cdcecfff7759d3a03c644bb0
Author: oxygen311 <al...@...>
Date:   2018-07-02T16:31:09Z

    Add rename method to rest api

commit 4df7c6dbaee5c3702f8da6d21cd981a5a17c557d
Author: oxygen311 <al...@...>
Date:   2018-07-03T12:07:23Z

    Add rename method to rest api

----


---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580]

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/3049
  
    Thanks @oxygen311 for the contribution. Could you resolve conflict and see if it passes CI?


---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3049
  
    @oxygen311 Could you please resolve conflicts? I recommend you not to change the unrelated code to avoid merge conflicts. After resolving, I'll merge it


---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3049
  
    LGTM


---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/3049
  
    LGTM


---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/3049
  
    Thanks. 


---

[GitHub] zeppelin issue #3049: [ZEPPELIN-3580] Adds rename note method to rest api

Posted by oxygen311 <gi...@git.apache.org>.

Github user oxygen311 commented on the issue:

    https://github.com/apache/zeppelin/pull/3049
  
    @jongyoul Done


---