You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/04/04 03:55:06 UTC

Re: Review Request: SQOOP-470 Create tests for blob support for Avro import

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4527/
-----------------------------------------------------------

(Updated 2012-04-04 01:55:06.194971)


Review request for Sqoop, Arvind Prabhakar and Bilung Lee.


Changes
-------

Add two more test cases regarding compression:
- Compressed Avro import inline
- Compressed Avro import external


Summary
-------

Add Avro blob import tests as part of thrid party test suite since Hsqldb does not support BLOB/CLOB type.

The changes include:

- abstract LobAvroImportTestCase class
  1) testBlobAvroImportInline: test inline import
  2) testBlobAvroImportExternal: test external file import
  3) testBlobAvroImportMultiCols: test multiple columns import

- OracleLobAvroImportTest class
- MySQLLobAvroImportTest class


This addresses bug SQOOP-470.
    https://issues.apache.org/jira/browse/SQOOP-470


Diffs (updated)
-----

  /src/test/com/cloudera/sqoop/manager/MySQLLobAvroImportTest.java PRE-CREATION 
  /src/test/com/cloudera/sqoop/manager/OracleLobAvroImportTest.java PRE-CREATION 
  /src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4527/diff


Testing
-------

Tested with Oracle XE 10g and MySQL 5.1

Ran ant test
Ran ant test -Dthirdparty=true
Ran ant checkstyle


Thanks,

Cheolsoo

Re: Review Request: SQOOP-470 Create tests for blob support for Avro import

Posted by Bilung Lee <bl...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4527/#review6748
-----------------------------------------------------------

Ship it!


- Bilung


On 2012-04-04 01:55:06, Cheolsoo Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4527/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 01:55:06)
> 
> 
> Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Add Avro blob import tests as part of thrid party test suite since Hsqldb does not support BLOB/CLOB type.
> 
> The changes include:
> 
> - abstract LobAvroImportTestCase class
>   1) testBlobAvroImportInline: test inline import
>   2) testBlobAvroImportExternal: test external file import
>   3) testBlobAvroImportMultiCols: test multiple columns import
> 
> - OracleLobAvroImportTest class
> - MySQLLobAvroImportTest class
> 
> 
> This addresses bug SQOOP-470.
>     https://issues.apache.org/jira/browse/SQOOP-470
> 
> 
> Diffs
> -----
> 
>   /src/test/com/cloudera/sqoop/manager/MySQLLobAvroImportTest.java PRE-CREATION 
>   /src/test/com/cloudera/sqoop/manager/OracleLobAvroImportTest.java PRE-CREATION 
>   /src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4527/diff
> 
> 
> Testing
> -------
> 
> Tested with Oracle XE 10g and MySQL 5.1
> 
> Ran ant test
> Ran ant test -Dthirdparty=true
> Ran ant checkstyle
> 
> 
> Thanks,
> 
> Cheolsoo
> 
>