[GitHub] [druid-website-src] 317brian commented on a diff in pull request #412: update build and copy scripts to use rsync --delete

["317brian (via GitHub)" <gi...@apache.org>]

317brian commented on code in PR #412:
URL: https://github.com/apache/druid-website-src/pull/412#discussion_r1296386637


##########
scripts/copy_druid_docs.py:
##########
@@ -90,15 +85,14 @@ def is_it_latest(druid_version, source_directory, destination_directory_latest):
 
     if is_latest == 'y':
         print("Also copying the docs to docs/latest.")
-        copy_tree(source_directory+'/docs', destination_directory_latest)
+        subprocess.run(["rsync", "-av", "--delete", f"{source_directory}/docs/", destination_directory_latest])

Review Comment:
   I'm not sure if we actually want the list of files being sent? I'm guessing no. If so, I can remove `-av` from this and 106



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org