You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/03/13 02:09:07 UTC
[kudu-CR] KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9598
Change subject: KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
......................................................................
KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
We need to coerce the BigDecimal values to the expected
scale to ensure they can be correctly decoded server side.
This was missed in the KuduPredicate implimentation though
we did it everywhere else.
I added the coercion and a test that will fail if it is ever removed.
Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/9598/1
--
To view, visit http://gerrit.cloudera.org:8080/9598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
Gerrit-Change-Number: 9598
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9598 )
Change subject: KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
......................................................................
KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
We need to coerce the BigDecimal values to the expected
scale to ensure they can be correctly decoded server side.
This was missed in the KuduPredicate implementation though
we did it everywhere else.
I added the coercion and a test that will fail if it is ever removed.
Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
Reviewed-on: http://gerrit.cloudera.org:8080/9598
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
2 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
Gerrit-Change-Number: 9598
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9598 )
Change subject: KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
lgtm
http://gerrit.cloudera.org:8080/#/c/9598/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9598/1//COMMIT_MSG@12
PS1, Line 12: implimentation
implementation
--
To view, visit http://gerrit.cloudera.org:8080/9598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
Gerrit-Change-Number: 9598
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 13 Mar 2018 03:08:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9598
to look at the new patch set (#2).
Change subject: KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
......................................................................
KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
We need to coerce the BigDecimal values to the expected
scale to ensure they can be correctly decoded server side.
This was missed in the KuduPredicate implementation though
we did it everywhere else.
I added the coercion and a test that will fail if it is ever removed.
Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
2 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/9598/2
--
To view, visit http://gerrit.cloudera.org:8080/9598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
Gerrit-Change-Number: 9598
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9598 )
Change subject: KUDU-2338: [Java] Coerce BigDecimal values in KuduPredicate
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e1e397524dfc2725b33b9683ebbdc38fe8cfc8
Gerrit-Change-Number: 9598
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 13 Mar 2018 03:10:53 +0000
Gerrit-HasComments: No